plugin: add Safari extension control skill#51
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR releases version 6.8.0 across all plugins and introduces a comprehensive Safari Extension Control Workflow skill in the Apple Dev Skills plugin. The workflow guides macOS developers through decision logic for selecting appropriate Safari integration surfaces (Web Extensions, Web Inspector Extensions, App Extensions, content blockers, SafariServices), with accompanying reference documentation, configuration management, and validation tests. ChangesVersion 6.8.0 Release with Safari Extension Control Workflow
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@plugins/apple-dev-skills/skills/safari-extension-control-workflow/references/messaging-shared-data-and-permissions.md`:
- Line 43: The wording for SFSafariPage.dispatchMessageToScript is ambiguous;
update the sentence to clearly state that this API is called from the extension
to send a message into the page's injected script context (extension-to-script
dispatch), rather than implying the message originates from the page; reference
SFSafariPage.dispatchMessageToScript in the revised phrasing so it reads like
"extension-side dispatch to the injected script context (use
SFSafariPage.dispatchMessageToScript)" to avoid confusion.
In `@plugins/apple-dev-skills/skills/safari-extension-control-workflow/SKILL.md`:
- Line 113: The recommendation line contains a duplicated term ("App
Extensions") in the phrase "SafariServices, Web Extensions, App Extensions,
AuthenticationServices, or App Extensions."; edit SKILL.md to remove the
redundant second "App Extensions" so the list reads correctly (e.g.,
"SafariServices, Web Extensions, App Extensions, AuthenticationServices" or
replace the duplicate with the intended API if different), ensuring the sentence
remains grammatical and user-facing guidance is clear.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: b74c04af-29cb-4b35-92dc-16a92284f350
⛔ Files ignored due to path filters (8)
plugins/agent-plugin-skills/uv.lockis excluded by!**/*.lockplugins/apple-dev-skills/uv.lockis excluded by!**/*.lockplugins/cardhop-app/mcp/uv.lockis excluded by!**/*.lockplugins/productivity-skills/uv.lockis excluded by!**/*.lockplugins/python-skills/uv.lockis excluded by!**/*.lockplugins/things-app/mcp/uv.lockis excluded by!**/*.lockplugins/things-app/uv.lockis excluded by!**/*.lockuv.lockis excluded by!**/*.lock
📒 Files selected for processing (38)
plugins/agent-plugin-skills/.codex-plugin/plugin.jsonplugins/agent-plugin-skills/pyproject.tomlplugins/apple-dev-skills/.codex-plugin/plugin.jsonplugins/apple-dev-skills/.github/scripts/sync_shared_snippets.shplugins/apple-dev-skills/.github/scripts/validate_repo_docs.shplugins/apple-dev-skills/README.mdplugins/apple-dev-skills/ROADMAP.mdplugins/apple-dev-skills/docs/maintainers/customization-consolidation-review.mdplugins/apple-dev-skills/pyproject.tomlplugins/apple-dev-skills/skills/safari-extension-control-workflow/SKILL.mdplugins/apple-dev-skills/skills/safari-extension-control-workflow/agents/openai.yamlplugins/apple-dev-skills/skills/safari-extension-control-workflow/references/customization-flow.mdplugins/apple-dev-skills/skills/safari-extension-control-workflow/references/customization.template.yamlplugins/apple-dev-skills/skills/safari-extension-control-workflow/references/extension-shape-decision.mdplugins/apple-dev-skills/skills/safari-extension-control-workflow/references/messaging-shared-data-and-permissions.mdplugins/apple-dev-skills/skills/safari-extension-control-workflow/references/safari-services-control-surfaces.mdplugins/apple-dev-skills/skills/safari-extension-control-workflow/references/snippets/apple-xcode-project-core.mdplugins/apple-dev-skills/skills/safari-extension-control-workflow/references/testing-debugging-and-distribution.mdplugins/apple-dev-skills/skills/safari-extension-control-workflow/references/web-inspector-extensions.mdplugins/apple-dev-skills/skills/safari-extension-control-workflow/scripts/customization_config.pyplugins/apple-dev-skills/tests/test_customization_consolidation_review.pyplugins/apple-dev-skills/tests/test_customization_template_paths.pyplugins/apple-dev-skills/tests/test_safari_extension_control_workflow.pyplugins/cardhop-app/.codex-plugin/plugin.jsonplugins/cardhop-app/mcp/pyproject.tomlplugins/dotnet-skills/.codex-plugin/plugin.jsonplugins/productivity-skills/.codex-plugin/plugin.jsonplugins/productivity-skills/pyproject.tomlplugins/python-skills/.codex-plugin/plugin.jsonplugins/python-skills/pyproject.tomlplugins/rust-skills/.codex-plugin/plugin.jsonplugins/spotify/.codex-plugin/plugin.jsonplugins/swiftasb-skills/.codex-plugin/plugin.jsonplugins/things-app/.codex-plugin/plugin.jsonplugins/things-app/mcp/pyproject.tomlplugins/things-app/pyproject.tomlplugins/web-dev-skills/.codex-plugin/plugin.jsonpyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Summary by CodeRabbit
New Features
Documentation
Tools
Tests
Chores